assertOptionByText() is missing on AssertLegacyTrait, let's add it to make Simpletest conversion to browser tests easier.

CommentFileSizeAuthor
#2 2862470-2.patch1.63 KBjofitz

Comments

klausi created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2862470-2.patch1.63 KB

$this->assertSession()->optionExists() (as used in assertOption()) checks option text (as well as option value).

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +DevDaysSeville

Excellent, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 458de4e to 8.4.x and d3b67f8 to 8.3.x. Thanks!

  • alexpott committed 458de4e on 8.4.x 
    Issue #2862470 by Jo Fitzgerald, klausi: Add assertOptionByText() to...

  • alexpott committed d3b67f8 on 8.3.x 
    Issue #2862470 by Jo Fitzgerald, klausi: Add assertOptionByText() to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.