Drupal\domain_access\DomainAccessManager does not have a method 'getDefaultAllValue' in Drupal\Core\Field\FieldConfigBase->getDefaultValue()

see #5

Applied #2 patch and changed method name to 8005 to force the update. Update went through. Now the problem appears when adding a new node. Any ideas?

Issue

Warning: call_user_func() expects parameter 1 to be a valid callback, class 'Drupal\domain_access\DomainAccessManager' does not have a method 'getDefaultAllValue' in Drupal\Core\Field\FieldConfigBase->getDefaultValue() (line 388 of core\lib\Drupal\Core\Field\FieldConfigBase.php).

Update DB

> drush updb
The following updates are pending:
domain_alpha module :
  8005 -   Make all affiliates default value configurable.
Do you wish to run all pending updates? (y/n): y
Performing domain_alpha_update_8005                                                                                                                                [ok]
Cache rebuild complete.                                                                                                                                            [ok]
Finished performing updates.

---------------------------

New Code

/**
 * Make all affiliates default value configurable.
 */
function domain_alpha_update_8005() {
  $config = \Drupal::configFactory();
  $field_name = '.' . DOMAIN_ACCESS_ALL_FIELD;
  // Iterate over all node & user fields.
  foreach (['node', 'user'] as $type) {
    foreach ($config->listAll('field.field.' . $type . '.') as $field_id) {
      if (substr($field_id, -strlen($field_name)) === $field_name) {
        $field = $config->getEditable($field_id);
        if ($field->get('default_value_callback') === 'Drupal\domain_access\DomainAccessManager::getDefaultValue') {
          $field
            ->clear('default_value_callback')
            ->save(TRUE);
        }
      }
    }
  }
}

Okay, I got it now.

My config for all content types looked like this before update, so 'if' statement never executed (as you've rightly guessed!)

uuid: f6b83cb2-0a9f-4101-a9db-557fc4d33610
langcode: en
status: true
dependencies:
  config:
    - field.storage.node.field_domain_all_affiliates
    - node.type.fact
id: node.fact.field_domain_all_affiliates
field_name: field_domain_all_affiliates
entity_type: node
bundle: fact
label: 'Send to all affiliates'
description: 'Make this content available on all domains.'
required: false
translatable: true
default_value: {  }
default_value_callback: 'Drupal\domain_access\DomainAccessManager::getDefaultAllValue'
settings:
  on_label: 'On'
  off_label: 'Off'
field_type: boolean

So I kept the if statement and just reverted to original version (check for getDefaultAllValue). After drush updb everything looks good now. Thanks Ken!

function domain_alpha_update_8006() {
  $config = \Drupal::configFactory();
  $field_name = '.' . DOMAIN_ACCESS_ALL_FIELD;
  // Iterate over all node & user fields.
  foreach (['node', 'user'] as $type) {
    foreach ($config->listAll('field.field.' . $type . '.') as $field_id) {
      if (substr($field_id, -strlen($field_name)) === $field_name) {
        $field = $config->getEditable($field_id);
        if ($field->get('default_value_callback') === 'Drupal\domain_access\DomainAccessManager::getDefaultAllValue') {
          $field
            ->clear('default_value_callback')
            ->save(TRUE);
        }
      }
    }
  }
}