Plus one day on Date only fields with custom display widget for pacific/auckland timezone

Confirmed :(

Not sure what we botched in #2739290: UTC+12 is broken on date only fields, but it looks like the custom and plain formatters aren't honoring the logic to ignore the time-portion for date-only formats. Also not sure why the timezone loop in those tests isn't catching this.

Downgrading this, as I don't think this qualifies as a Major.

As a workaround, I think the best action is to create a custom date format under admin/config/regional/date-time, use the Default formatter, and then pick the custom format you just made. That seems to work for me.

DateTimeFieldTest::testDateField() tests all the formatters in the zone loop. UTC+12 and UTC+13 are in there. I have no clue what is up. And, the attached passes locally.

This works with manual testing. I am really confused about what is going on with the test coverage and how this slipped through.

Still still needs test adjustments.

This should come up green, but I can't figure out a way to make the plain formatters fail w/o the fix.

@Pharitz, can you test this to see if it fixes your problem?

Tests have been converted to phpunit.

I can't figure out a way to make the plain formatters fail w/o the fix.

Is it an issue with the plain formatter?

Re-rolled.

> I can't figure out a way to make the plain formatters fail w/o the fix.

Me and @kim.pepper did! :)

See #3009377-68: Replace drupal_get_user_timezone with a date_default_timezone_get() and an event listener for the explanation why it didn't fail in HEAD. Came up with the same fix as this did over there after a lot of painful debugging.

I guess we can close this as a duplicate.

Re-rolled

+++ b/core/modules/datetime/src/Plugin/Field/FieldFormatter/DateTimeCustomFormatter.php
@@ -55,7 +55,7 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
+    $timezone = $this->getSetting('timezone_override') ?: $date->getTimezone()->getName();
     return $this->dateFormatter->format($date->getTimestamp(), 'custom', $format, $timezone != '' ? $timezone : NULL);

We've now got two ternary operators for the $timezone in two different places, which makes it hard to read.
Is the existing ternary still needed -- can $timezone still be '' with the new code?

If so, the logic should all be combined into one part of code (though avoid nesting ternaries for readability please...).

If not, it should be removed.

Tentatively closing this as a dup, since the same code is essentially also in #3009377: Replace drupal_get_user_timezone with a date_default_timezone_get() and an event listener, which is currently RTBC.

I do agree with the comment in #17, though, but I think we can make that a novice followup task once ^^ lands.