Problem/Motivation

Detailed cron log description is not translatable.

(/admin/config/system/cron)

Run times of individual cron jobs will be written to watchdog

Proposed resolution

Use t() method in this form.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 drupal-use-t-method-to-detailed-cron-log-description-2861745-2-drupal-8.3.x-dev.patch712 bytesu7aro

Comments

Yutaro Ohno created an issue. See original summary.

u7aro’s picture

u7aro
Primary language Japanese
Location Japan
commented
StatusFileSize
new drupal-use-t-method-to-detailed-cron-log-description-2861745-2-drupal-8.3.x-dev.patch712 bytes
idebr’s picture

idebr commented
Status: Active » Needs review
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

I am not sure if this can make it in to 8.3.x since it is already at RC1, but it applies cleanly on both 8.3.x and 8.4.x.

  • lauriii committed de3fde9 on 8.4.x 
    Issue #2861745 by Yutaro Ohno: Detailed cron log description is not...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed de3fde9 and pushed to 8.4.x. Thanks!

As a translation string addition (rather than change), it might be possible to include this bug fix also in a 8.3.x patch release. Let's get sign off from another maintainer for that.

sahilsharma011’s picture

sahilsharma011 commented

I applied patch given in #2 and it applies cleanly to branch 8.3.x
This patch can be backported cleanly.

sahilsharma011’s picture

sahilsharma011 commented
Status: Patch (to be ported) » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.3.x-dev » 8.4.x-dev
Status: Needs review » Fixed

We are supposed to freeze strings with the release candidates, and only break that for critically important changes. Since this is such a minor improvement, let's not break our freeze for that. Discussed with @lauriii and @xjm.

  • catch committed e346bdc on 8.3.x authored by lauriii 
    Issue #2861745 by Yutaro Ohno: Detailed cron log description is not...

  • catch committed 60a1b8e on 8.3.x 
    Revert "Issue #2861745 by Yutaro Ohno: Detailed cron log description is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.