This is probably on your radar for the path forward on the D8 version, but just wanted to put it out here since it's a feature we loved in the D7 version and are missing it in D8 sites using this module. Thanks for such a great and indispensable module

CommentFileSizeAuthor
#5 3125687-4.patch6.64 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

scotself created an issue. See original summary.

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
CreditAttribution: scotwith1t commented
Issue summary: View changes
gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented

My users also strongly miss the popup warning.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
idebr’s picture

idebr CreditAttribution: idebr at iO commented
FileSize
3125687-4.patch6.64 KB

A popup warning when browsing away does not seem like something that should be tied to content locking. I would suggest using the Confirm Leave module for that.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Consensus Enterprises for Health Canada - HPFB commented
Status: Active » Closed (works as designed)

Agreed.

gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented

@idebr : You wrote that a popup warning should not be part of content_lock (as it was in the D7 version).
But your patch #5 does add a JS popup (just from looking at it) - am I right?

idebr’s picture

idebr CreditAttribution: idebr at iO commented

#7 Yes, the patch includes a popup. The code is an exact copy of the confirm_leave module.