There is a missing comma at the end of line 210 of views_merge_rowsDisplayExtenderPlugin.php

Creating the following error:

The website encountered an unexpected error. Please try again later.
ParseError: syntax error, unexpected quoted-string (T_CONSTANT_ENCAPSED_STRING), expecting ']' in Composer\Autoload\includeFile() (line 161 of modules/contrib/views_merge_rows/src/Plugin/views/display_extender/views_merge_rowsDisplayExtenderPlugin.php).

Adding a comma at the end of the line corrects the issue.

Will try to get a chance to make a patch but will be much later before I get a chance.

CommentFileSizeAuthor
#7 views-merge-rows-syntax-error-on-new-install-2859658-7.patch2.41 KBrodrigoaguilera
#6 views-merge-rows-syntax-error-on-new-install-2859658-6.patch2.07 KBrodrigoaguilera
#4 views-merge-rows-syntax-error-on-new-install-2859658-4.patch1.67 KBrodrigoaguilera
#2 views-merge-rows-syntax-error-on-new-install-2859658-2.patch1.36 KBahmad abbad

Comments

Christopher Riley created an issue. See original summary.

ahmad abbad’s picture

ahmad abbad commented
StatusFileSize
new views-merge-rows-syntax-error-on-new-install-2859658-2.patch1.36 KB
ahmad abbad’s picture

ahmad abbad commented
Status: Active » Needs review
rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
StatusFileSize
new views-merge-rows-syntax-error-on-new-install-2859658-4.patch1.67 KB

Sadly this is not the only tweak that the 2.x branch needs

I think the module is great but rushing into releasing a stable version with syntax error was a mistake.

I hope so basic tests can be added to avoid this kind of situation.

dgagne’s picture

dgagne commented

I really want to apologize here. My WAMP seems to be able to run despite some syntax errors. The first time it happened, it was not that big; it was about my system being able to work while it should have been case sensitive with regards to path names. So i will rework the module and patch these syntax errors today and i Will also make the prior version available again.

I agree that tests should be added. I open a separate issue about this.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
StatusFileSize
new views-merge-rows-syntax-error-on-new-install-2859658-6.patch2.07 KB

I missed one getOptions

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented
StatusFileSize
new views-merge-rows-syntax-error-on-new-install-2859658-7.patch2.41 KB

There was a call to $this->voptionsFormSubmit

dgagne’s picture

dgagne commented
Status: Needs review » Reviewed & tested by the community

Fixed in 8.x-2.1.

rodrigoaguilera’s picture

rodrigoaguilera
Primary language Spanish
Location Madrid
commented

It would be nice to get some issue credit next time for the people who provided patches
https://www.drupal.org/drupalorg/blog/a-guide-to-issue-credits-and-the-d...

I'll test test this soon. I feel you expect me to set it as "Fixed". Am I right?

dgagne’s picture

dgagne commented
Status: Reviewed & tested by the community » Fixed

I tested it for what was found. I looked over and didn't find anything else. I don't know exactly when the crédit is given. I set it as fixed right now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.