Per https://groups.drupal.org/node/516400

CommentFileSizeAuthor
#3 2859618-3.patch647 byteslauriii
#2 2859618-2.patch611 byteslauriii

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new 2859618-2.patch611 bytes
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 2859618-3.patch647 bytes

Made the list of provisional committers follow alphabetical order

The last submitted patch, 2: 2859618-2.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Yay!

  • xjm committed 7d47a58 on 8.4.x 
    Issue #2859618 by lauriii: Add Gábor Hojtsy, Roy Scholten (yoroy) and...

  • xjm committed 768f140 on 8.3.x 
    Issue #2859618 by lauriii: Add Gábor Hojtsy, Roy Scholten (yoroy) and...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Since Dries has publicly signed off in https://groups.drupal.org/node/516400, any full committer can commit this patch, so I did!

We had a bit of multilingual fun as @yoroy noticed @Gábor's Hojtsy name being rendered without Unicode -- @lauriii figured out that Firefox does not use unicode by default for https://www.drupal.org/files/issues/2859618-3.patch and d.o apparently isn't sending the correct headers. We confirmed that it looks okay locally though with the existing listing for Gábor, and I double-checked that it was correct with the patch applied too. :)

Committed and pushed to 8.4.x and cherry-picked to 8.3.x. Hooray! Looking forward to collaborating with all of you more. :D

yoroy’s picture

yoroy commented

It's an honour and I'm excited to see what we will do. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.