Make use of entity_type.manager.

CommentFileSizeAuthor
#2 2859512-patch.patch693 byteschaitanya17

Comments

chaitanya17 created an issue. See original summary.

chaitanya17’s picture

chaitanya17 commented
StatusFileSize
new 2859512-patch.patch693 bytes

Please check attached working patch.

chaitanya17’s picture

chaitanya17 commented
Assigned: chaitanya17 » Unassigned
Status: Active » Needs review
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

Good catch, thanks!

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Needs review » Fixed

Fixed, applied patch in new release 8.x-1.4

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Fixed » Closed (fixed)
chaitanya17’s picture

chaitanya17 commented

@Gaurav_drupal Thanks for fixing issue, but I haven't yet received commit for this.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

@chaitanya17 As I am new to this committing process, I have manually applied the patch.

chaitanya17’s picture

chaitanya17 commented

@Gaurav_drupal, https://www.drupal.org/patch/apply check this document

Use this command to commit to your repo. Nothing Different.

git commit -m 'Issue #2859512 by chaitanya17: entityTypeManager should be used in static create function' --author="chaitanya17 <chaitanya17@1998300.no-reply.drupal.org>"

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

@chaitanya17 Thanks.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Closed (fixed) » Fixed
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Version: 8.x-1.x-dev » 8.x-1.5
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Fixed » Closed (fixed)