There are lots of commented code in files. Please cleanup your code.

CommentFileSizeAuthor
#8 Code-Cleanup-2859083-8.patch4.28 KBjeetendrakumar
#6 Code-Cleanup-2859083-6.patch7.21 KBjeetendrakumar

Comments

jeetendrakumar created an issue. See original summary.

jeetendrakumar’s picture

jeetendrakumar commented
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

I have updated the much cleaner code now.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

I will format the code and provide in next release.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Active » Needs review

@jeetendrakumar

jeetendrakumar’s picture

jeetendrakumar commented
Version: 8.x-1.0 » 8.x-1.4
StatusFileSize
new Code-Cleanup-2859083-6.patch7.21 KB

Hi Gaurav_drupal

Please apply attached patch file.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

@jeetendrakumar Thanks for the patch and your quick response., but it seems that I have already cleaned up much code which is in the patch. Secondly, the module was updated including module name also in 8.x-1.3. So, there is change in file names and respective hooks.

If possible you can review the revised code and help me on that.

jeetendrakumar’s picture

jeetendrakumar commented
StatusFileSize
new Code-Cleanup-2859083-8.patch4.28 KB

remove "simple_email_login.libraries.yml" file because there are no use of this file in this module.

Please find latest patch file.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Version: 8.x-1.4 » 8.x-1.5

@jeetendrakumar: Applied patch Code-Cleanup-2859083-8.patch

jeetendrakumar’s picture

jeetendrakumar commented

Look good. Now you can change status to fix.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented

@jeetendrakumar thanks for your help.

gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Needs review » Fixed
gaurav_drupal’s picture

gaurav_drupal
he/him
Primary language Hindi
Location Indore
commented
Status: Fixed » Closed (fixed)