Problem/Motivation

After the changes to the Field UI, extra fields were changed in #2824778: Hide the "Type" select for extra fields
This was done because the select list was nonsensical.

However, that value is used by tabledrag, and right now dragging an extra field like "Links" on nodes is broken.

Steps to reproduce:
Go to admin/structure/types/manage/article/display
Drag the "Links" field in the "Disabled" region

Expected:
The "Links" field is added to the "Disabled" region

Actual:
The "Links" field still follows your mouse, you can't really drop it, and there is an error in the JS console

Proposed resolution

Restore the input field, but as type=>hidden instead of type=>select

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new1.15 KB
new2.63 KB

The last submitted patch, 2: 2858852-field_ui-2-FAIL.patch, failed testing.

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Issue summary: View changes
tim.plunkett’s picture

Priority: Normal » Major

As this is site-builder-facing regression committed during the 8.3.x cycle, bumping to major.
You can turn off tabledrag and move the field, so it isn't critical.

swentel’s picture

Status: Needs review » Reviewed & tested by the community

Yep, fixes the issue.

tim.plunkett’s picture

Title: Extra fields cannot be used with tabledrag in Manage Display » [regression] Extra fields cannot be used with tabledrag in Manage Display
xjm’s picture

Title: [regression] Extra fields cannot be used with tabledrag in Manage Display » [8.3.x regression] Extra fields cannot be used with tabledrag in Manage Display
Version: 8.4.x-dev » 8.3.x-dev
Issue tags: +rc target

Since this is an 8.3.x regression let's make it an RC target also.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed aefca7b to 8.4.x and a1e06ed to 8.3.x. Thanks!

I manually tested following the steps to reproduce in the issue summary - also yay javascript tests!

  • alexpott committed aefca7b on 8.4.x
    Issue #2858852 by tim.plunkett: [8.3.x regression] Extra fields cannot...

  • alexpott committed a1e06ed on 8.3.x
    Issue #2858852 by tim.plunkett: [8.3.x regression] Extra fields cannot...
nod_’s picture

Issue tags: +JavaScript

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.