Closed (duplicate)
Project:
System stream wrapper
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2017 at 12:11 UTC
Updated:
29 Apr 2025 at 15:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bkhandruk commentedReplaced deprecated uses in module.
Comment #4
dave reidComment #5
martin107 commentedSo my review,
A) The idea behind the issue is sound.
B) Al changes are of the form
- $realpath = realpath(dirname($path)) . '/' . drupal_basename($path);
+ $realpath = realpath(dirname($path)) . '/' . \Drupal::service('file_system')->basename($path);
which is the standard conversion I expected to see.
B) Formally I can say there are no changes outside this type of conversion.
C) Thinking about the possibility of opening up new securitty holes? always a worry with this module.
I don;t think the possibility exists as drupal_basename is just a wrapper for the service->basename call
so the two represent identical code flow.
Comment #6
dave reidThis has already been fixed.