Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

Assigned: bkhandruk » Unassigned
Status: Active » Needs review
StatusFileSize
new1.82 KB

Replaced deprecated uses in module.

dave reid’s picture

martin107’s picture

Status: Needs review » Reviewed & tested by the community

So my review,

A) The idea behind the issue is sound.

B) Al changes are of the form

- $realpath = realpath(dirname($path)) . '/' . drupal_basename($path);
+ $realpath = realpath(dirname($path)) . '/' . \Drupal::service('file_system')->basename($path);

which is the standard conversion I expected to see.

B) Formally I can say there are no changes outside this type of conversion.

C) Thinking about the possibility of opening up new securitty holes? always a worry with this module.

I don;t think the possibility exists as drupal_basename is just a wrapper for the service->basename call
so the two represent identical code flow.

dave reid’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

This has already been fixed.