The "User has a revision" views argument handler generates a SQL error

This fix would get this inline with the code in \Drupal\node\Plugin\views\filter\UidRevision so that looks good.

This still needs a test though.

@Artusamak nice! Looks really good already.

1. +++ b/core/modules/node/src/Tests/Views/ArgumentUidRevisionTest.php
   @@ -0,0 +1,54 @@
   +class ArgumentUidRevisionTest extends NodeTestBase {
   

   Ideally this would be a kernel test. We are not using the browser at all, so we can save 30 seconds of test time by leaving the browser out of this. Something like \Drupal\Tests\node\Kernel\Views\NidArgumentTest should point out how you can set this up, the actual test bit you wrote should just work there too. Just setting up and generating the content is slightly different.

2. +++ b/core/modules/node/src/Tests/Views/ArgumentUidRevisionTest.php
   @@ -0,0 +1,54 @@
   +  /**
   +   * Views used by this test.
   +   *
   +   * @var array
   +   */
   

   Nitpick: can just be {@inheritdoc}

@Artusamak++

+++ b/core/modules/node/tests/src/Kernel/Views/ArgumentUidRevisionTest.php
@@ -0,0 +1,93 @@
+namespace Drupal\node\Tests\Kernel\Views;

Needs to be namespace Drupal\Tests\node\Kernel\Views; the testbot actually cares about that and running it locally doesn't (unless you run it through run-tests.sh)

+++ b/core/modules/node/tests/src/Kernel/Views/ArgumentUidRevisionTest.php
@@ -0,0 +1,93 @@
+    $this->assertIdenticalResultset($view, $expected_result, ['nid' => 'nid'], 'Make sure that the view only returns nodes which match either the node or the revision author.');

We don't do error messages anymore, so that error string can be taken out.

@Artusamak nice work. We have a fix and we have a test.

Queued tests for Postgres and sqlite to be on the safe side.

Unrelated fail, see #2825845: DST-related test failures in FilterDateTimeTest

Retest passed, back to RTBC

And more unrelated fails. And back to RTBC.

Committed and pushed fb8335a to 8.4.x and ed83d7e to 8.3.x. Thanks!

Great to see more and more views test coverage.