The DbLogController::overview() method has two @see statements that are not up to date.
@see dblog_clear_log_form()
@see dblog_event()
This functions do not longer exists in Drupal 8 and should be replaced by:
@see Drupal\dblog\Form\DblogClearLogConfirmForm
@see Drupal\dblog\Controller\DbLogController::eventDetails()
Also the DbLogController::topLogMessage has an old comment line:
*
* Use one of the above *Report() methods.
That line can be deleted too.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff-2857909-3-5.txt | 496 bytes | chiranjeeb2410 |
| #5 | 2857909-5.patch | 976 bytes | chiranjeeb2410 |
| #3 | 2857909-3.patch | 976 bytes | chiranjeeb2410 |
Comments
Comment #2
chiranjeeb2410 commentedWill be working on this.
Comment #3
chiranjeeb2410 commentedMade required changes and removed unnecessary comment. Please Review.
Comment #4
dagmarThanks! Let's remove also some empty lines in the topRecentMessges method.
The patch could leave only one empty line between the description and the @param section as described in the documentation:
https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...
Comment #5
chiranjeeb2410 commented@dagmar,
Empty lines removed as per instructions. Uploading fresh patch with interdiff.
Please review.
Comment #6
dagmarThanks @chiranjeeb2410!
Comment #7
alexpottCommitted and pushed 5cd9a2b to 8.4.x and 8ccaa65 to 8.3.x. Thanks!
Comment #10
alexpottI committed this to 8.3.x as it only contains documentation fixes.