The DbLogController::overview() method has two @see statements that are not up to date.

@see dblog_clear_log_form()
@see dblog_event()

This functions do not longer exists in Drupal 8 and should be replaced by:

@see Drupal\dblog\Form\DblogClearLogConfirmForm
@see Drupal\dblog\Controller\DbLogController::eventDetails()

Also the DbLogController::topLogMessage has an old comment line:

   *
   * Use one of the above *Report() methods.

That line can be deleted too.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

dagmar created an issue. See original summary.

chiranjeeb2410’s picture

Assigned: Unassigned » chiranjeeb2410

Will be working on this.

chiranjeeb2410’s picture

Status: Active » Needs review
FileSize
976 bytes

Made required changes and removed unnecessary comment. Please Review.

dagmar’s picture

Status: Needs review » Needs work

Thanks! Let's remove also some empty lines in the topRecentMessges method.

The patch could leave only one empty line between the description and the @param section as described in the documentation:

https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...

chiranjeeb2410’s picture

Status: Needs work » Needs review
FileSize
976 bytes
496 bytes

@dagmar,

Empty lines removed as per instructions. Uploading fresh patch with interdiff.
Please review.

dagmar’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @chiranjeeb2410!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +documentation

Committed and pushed 5cd9a2b to 8.4.x and 8ccaa65 to 8.3.x. Thanks!

  • alexpott committed 5cd9a2b on 8.4.x
    Issue #2857909 by chiranjeeb2410, dagmar: DbLogController needs some...

  • alexpott committed 8ccaa65 on 8.3.x
    Issue #2857909 by chiranjeeb2410, dagmar: DbLogController needs some...
alexpott’s picture

I committed this to 8.3.x as it only contains documentation fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.