Closed (fixed)
Project:
Drupal core
Version:
8.3.x-dev
Component:
other
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Mar 2017 at 14:27 UTC
Updated:
2 Apr 2017 at 22:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
vegantriathletePatch attached!
Comment #3
vegantriathleteI hadn't done a `git pull` on 8.4.x before I rolled the previous patch. Let's see if it applies. If not, I'll reroll it.
Comment #4
vegantriathleteComment #5
Aanal.addweb commented@vegantriathlete, Thanks for the patch corrections, i checked by applying patch manually in module file.
Comment #8
xjmNeither of these grammatical errors could be caught by any automated test, so it makes sense to just fix them.
The first docblock raises some questions and has an untracked @todo, but that's out of scope here.
Committed to 8.4.x. As a documentation improvement, this issue is also RC eligible, so I've backported it to 8.3.x. Thanks @vegantriathlete!
Thanks @dhwani.addweb for reviewing. We generally do not need to confirm that the patch applies. Our automated infrastructure confirms that for us. For documentation improvements, we value your help evaluating the documentation and deciding how it can be better. In the case of this issue, I confirmed that the two grammar fixes were correct. When you review a patch, describe what you thought about and the questions you asked yourself. This is helpful for other reviewers to see what's been considered.
Comment #9
xjm