A couple of comments have words, that though spelled correctly, that are not grammatically correct.

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

Assigned: vegantriathlete » Unassigned
Status: Active » Needs review
StatusFileSize
new1021 bytes

Patch attached!

vegantriathlete’s picture

Priority: Normal » Minor

I hadn't done a `git pull` on 8.4.x before I rolled the previous patch. Let's see if it applies. If not, I'll reroll it.

vegantriathlete’s picture

Issue tags: +Quick fix
Aanal.addweb’s picture

Status: Needs review » Reviewed & tested by the community

@vegantriathlete, Thanks for the patch corrections, i checked by applying patch manually in module file.

  • xjm committed e59c5e6 on 8.4.x
    Issue #2857853 by vegantriathlete: Correct typos in DefaultConfigTest....

  • xjm committed 26809af on 8.3.x
    Issue #2857853 by vegantriathlete: Correct typos in DefaultConfigTest....
xjm’s picture

Status: Reviewed & tested by the community » Fixed

Neither of these grammatical errors could be caught by any automated test, so it makes sense to just fix them.

The first docblock raises some questions and has an untracked @todo, but that's out of scope here.

Committed to 8.4.x. As a documentation improvement, this issue is also RC eligible, so I've backported it to 8.3.x. Thanks @vegantriathlete!

Thanks @dhwani.addweb for reviewing. We generally do not need to confirm that the patch applies. Our automated infrastructure confirms that for us. For documentation improvements, we value your help evaluating the documentation and deciding how it can be better. In the case of this issue, I confirmed that the two grammar fixes were correct. When you review a patch, describe what you thought about and the questions you asked yourself. This is helpful for other reviewers to see what's been considered.

xjm’s picture

Version: 8.4.x-dev » 8.3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.