A comment in core/modules/views_ui/tests/src/Kernel/TagTest.php has a typo. Instead of Make sure just ten results are returns. it should be Make sure just ten results are returned.

CommentFileSizeAuthor
#8 correct_typo_in_TagTest-2857780-8.patch712 bytesvegantriathlete
#6 correct_typo_in_TagTest-2857780-6.patch717 bytesvegantriathlete
#2 correct_typo_in_comment-2857780-2.patch717 bytesvegantriathlete

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Assigned: vegantriathlete » Unassigned
Status: Active » Needs review
StatusFileSize
new correct_typo_in_comment-2857780-2.patch717 bytes

Patch attached!

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Title: Correct typo in comment » Correct typo in comment in TagTest.php
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 8.2.x-dev » 8.4.x-dev
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Makes sense, thanks!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Ah, does not apply anymore to 8.4.x, can you reroll?

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Status: Needs work » Needs review
StatusFileSize
new correct_typo_in_TagTest-2857780-6.patch717 bytes

New patch attached

Status: Needs review » Needs work

The last submitted patch, 6: correct_typo_in_TagTest-2857780-6.patch, failed testing.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Status: Needs work » Needs review
StatusFileSize
new correct_typo_in_TagTest-2857780-8.patch712 bytes

Gah! I didn't do a `git pull` in the 8.4.x branch before I rolled the patch. Here's a new one.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

Another one that won't be caught by the spellcheck since it's a real word. Thanks @vegantriathlete!

As a documentation fix, this issue is eligible for the 8.3.x RC as well. So, committed to 8.4.x and cherry-picked to 8.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.