The Doc Block for core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php ::assertLinkByHref has an annotation for @deprecated that states Use $this->assertSession()->linkByHref() instead.. It should state Use $this->assertSession()->linkByHrefExists() instead.

CommentFileSizeAuthor
#2 Correct_assertLinkByHref_documentation-2857580-2.patch699 bytesvegantriathlete
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
CreditAttribution: vegantriathlete commented
Assigned: vegantriathlete » Unassigned
Status: Active » Needs review
FileSize
Correct_assertLinkByHref_documentation-2857580-2.patch699 bytes

Patch attached!

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 8.2.x-dev » 8.3.x-dev
Status: Needs review » Reviewed & tested by the community
  • Patch applies cleanly.
  • Documentation improved.
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Reviewed & tested by the community » Patch (to be ported)

Good catch! $this->assertSession()->linkByHref() has never existed and there are no other references to this method in Drupal core.

Committed 0101662 and pushed to 8.4.x. Since this only improves documentation, this could be considered to be backported to 8.3.x.

  • lauriii committed 0101662 on 8.4.x 
    Issue #2857580 by vegantriathlete: Correct documentation on...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Agreed, as a documentation bugfix, this can be backported. Thanks @lauriii and @vegantriathlete!

  • lauriii committed 2a7ffca on 8.3.x 
    Issue #2857580 by vegantriathlete: Correct documentation on...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Reviewed & tested by the community » Fixed

Thanks for confirming @xjm! Cherry picked and pushed to 8.3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.