There is a leftover call to l() in SoundCloudDefaultFormatter.php:265, which does not exist in Drupal 8.

The same line also contains a bad ! placeholder. Markup placeholders can't be used in D8, and link elements need to be part of the translation string.

CommentFileSizeAuthor
#5 soundcloudfield-2857050-5.patch842 bytescburschka
#4 soundcloudfield-2857050-2.patch1.19 KBpifagor

Comments

cburschka created an issue. See original summary.

cburschka’s picture

cburschka
they
commented
Title: rror: Call to undefined function Drupal\soundcloudfield\Plugin\Field\FieldFormatter\l() » Call to undefined function Drupal\soundcloudfield\Plugin\Field\FieldFormatter\l()
Issue summary: View changes
cburschka’s picture

cburschka
they
commented
Issue summary: View changes
pifagor’s picture

pifagor commented
Status: Active » Needs review
StatusFileSize
new soundcloudfield-2857050-2.patch1.19 KB

patch

cburschka’s picture

cburschka
they
commented
StatusFileSize
new soundcloudfield-2857050-5.patch842 bytes

This doesn't quite work, as far as I can tell:

Cannot use object of type Drupal\soundcloudfield\Plugin\Field\FieldType\SoundCloudItem as array in Drupal\soundcloudfield\Plugin\Field\FieldFormatter\SoundCloudDefaultFormatter->viewElements()

The correct way to access the url should be $item->url.

(The invalid !placeholder also doesn't work.)

  • cburschka authored 7648ca4 on 8.x-1.x 
    Issue #2857050 by cburschka: Call to undefined function Drupal\...
attila.fekete’s picture

attila.fekete commented
Status: Needs review » Fixed

@cburschka: thanks for the patch, @pifagor: your patch didn't work for me either

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pifagor’s picture

pifagor commented
lakshmandrupal’s picture

lakshmandrupal commented

#5 worked for me