The fact that focal point typically uses relative coordinates to represent itself and crop API uses absolute coordinates has led to a bit of confusion. Lets improve the documentation in FocalPointManagerInterface to make this less confusing for users
ORIGINAL SUMMARY (@dave reid)
I also found the docs for \Drupal\focal_point\FocalPointManagerInterface::saveCropEntity confusing because the X and Y coordinates are relative like a percentage, and not the actual X and Y coordinates.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | x_and_y_arguments_in-2856994-3.patch | 3.61 KB | bleen |
| #2 | 2856994-improve-x-y-coordinate-docs.patch | 836 bytes | dave reid |
Comments
Comment #2
dave reidComment #3
bleen commentedI slightly broadened the scope of this issue to include all the comments in FocalPointManagerInterface since a person who finds the saveCropEntity docs confusing is likely to find all the docs confusing for roughly the same reason.
Comment #4
bleen commentedI think this is objectively an improvement in the docs and there is no risk of anything breaking since there are no code changes .... committing