Problem/Motivation

  • Create a view showing Content (teasers) with a Geolocation field.
  • Add ID, title and location fields from Content.
  • Set the formatter to "Geolocation Google Maps API - CommonMap".
  • On the formatter options, check "Show raw locations" and "On clicking marker scroll to result instead of opening marker bubble".
  • Set the Geolocation, Title and ID source fields.
  • In the Google Map settings, uncheck "Automatically show info text".
  • Save the view.
  • Open the view and click a location marker icon. The page scrolls to the teaser but still opens the bubble as well.

Proposed resolution

Since splitting geolocation-google-maps-api.js and geolocation-common-map.js, there is no longer an else clause where the bubble is opened only when the scrolling is disabled. A marker click event however, does pass a MouseEvent that has a stop() method. Sadly, the event for opening the bubble comes before the scrolling one.

The solution is to, in geolocation-common-map.js when scrolling is enabled, remove all current click event listeners on the marker before adding the new click listener.

Remaining tasks

Nothing(?)

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

dietr_ch created an issue. See original summary.

dietr_ch’s picture

Status: Active » Needs review
StatusFileSize
new953 bytes

Attached patch.

Status: Needs review » Needs work

The last submitted patch, 2: marker-scroll-still-opens-bubble-2855414-2.patch, failed testing.

dietr_ch’s picture

Status: Needs work » Needs review
christianadamski’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.