Closed (fixed)
Project:
Restrict IP
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Feb 2017 at 06:06 UTC
Updated:
11 Mar 2017 at 13:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
oinuma commentedComment #3
oinuma commentedComment #4
jaypanThanks for submitting a patch and maintaining my code formatting. I'll take a look at this over the next couple of days, and if it works alright, I'll create tests for it, and commit it.
Comment #5
jaypanYour patch doesn't work. It's trying to patch a file that doesn't exist.
Comment #6
oinuma commentedSorry, I made a mistake in making patches
Comment #7
jaypanOk, I've reviewed your patch, and it works. There were a couple issues though:
1) It didn't use Dependency injection
2) There was a formatting issue
Anyways I fixed these, and I'm going to credit you with the patch, however I'm not able to push to the Drupal git repository right now. I've opened up a ticket in the infrastructure queue, so once it gets resolved, I'll push the code.
However, before this can be released, I need to write automated tests for the patch, so I'm marking this as needs work until I get those done (or someone else does).
Comment #9
jaypanComment #10
jaypanTests have been added, code committed. Will release a new version.