I want to use wildcard in Whitelisted pages and Blacklisted pages paths.
So, I made a patch.

Comments

oinuma created an issue. See original summary.

oinuma’s picture

Assigned: oinuma » Unassigned
oinuma’s picture

StatusFileSize
new1.29 KB
jaypan’s picture

Thanks for submitting a patch and maintaining my code formatting. I'll take a look at this over the next couple of days, and if it works alright, I'll create tests for it, and commit it.

jaypan’s picture

Status: Active » Needs work

Your patch doesn't work. It's trying to patch a file that doesn't exist.

oinuma’s picture

Status: Needs work » Needs review
StatusFileSize
new1.47 KB

Sorry, I made a mistake in making patches

jaypan’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

Ok, I've reviewed your patch, and it works. There were a couple issues though:

1) It didn't use Dependency injection
2) There was a formatting issue

Anyways I fixed these, and I'm going to credit you with the patch, however I'm not able to push to the Drupal git repository right now. I've opened up a ticket in the infrastructure queue, so once it gets resolved, I'll push the code.

However, before this can be released, I need to write automated tests for the patch, so I'm marking this as needs work until I get those done (or someone else does).

  • Jaypan committed 7e63fec on 8.x-1.x authored by oinuma
    Issue #2854768 by oinuma: Use a wildcard path
    
jaypan’s picture

jaypan’s picture

Status: Needs work » Fixed

Tests have been added, code committed. Will release a new version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.