The Drupal 8 module has had a few issues that are a result of its stream wrapper implementation. There is another ticket to implement the rewritten stream wrapper from 7.3.x which tries to rely on the AWS SDK's S3 stream wrapper wherever necessary.

For such a major change to the module, we need to do the following:

The next steps:
- General code review
- Solve this issues:
-- #2856612: S3fsStream always uses the credentials not the profile
-- #2854735: Custom hostname not working in Drupal 8
-- #2811455: Allow ACLs to be overridden
-- #2856566: Getting 0 bytes files when copying from remote
-- #2855626: Aws\S3\Exception\S3Exception: Error executing "GetObject" on s3.amazonaws when image not exists.
-- #2858239: Change twig compiled files storage destination
- Update README.txt (done)
- Test, test and test.

In alpha we will work in:
- #2812749: IAM Credentials usage
- #2828403: s3fs module does not validate that the acess key + secret key has the permissions to put/upload the file into the bucket
- #2854683: Port Automated Tests from D7 to D8.8/D9.1
- Performance Issues.

Comments

steel-track created an issue. See original summary.

jansete’s picture

jansete commented

Haha I've created 8.x-3.x branch ten minutes ago, now it's time to work in it!

steel-track’s picture

steel-track commented
Issue summary: View changes
steel-track’s picture

steel-track commented

@jansete - Awesome! What is your plan? I captured three items above. Is there anything else that needs to be in a 3.x branch? Also, do you agree we should deprecate the 2.x branch after the release of the 3.x branch?

steel-track’s picture

steel-track commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
steel-track’s picture

steel-track commented
Title: Create 8.3.x version of S3FS » 8.3 Alpha Release of S3FS
jansete’s picture

jansete commented

Hi steel-track,

Now the 8.x-2.x branch is marked like not supported, I added in the release notes and the project description that update to new branch, and now it's easier because is the same code base.

This is my plan to road to alpha, I hear suggestions:

Basically, it's working the main features of the module working with the last aws sdk and looking into 7.x-3.x integration. Some of them now it's implemented, we have to review in the new way if we needed.

- Public and private streamwrapper replace.
- S3FS use per field.
- S3FS Assets.
- Form and settings.php configuration.
- Updated README.
- Replace Drupal deprecated methods and functions.
- Coding standards.
- Drush integration.
- Resolve errors/warnings related basic use.
- Clean comments.
- Add actions page.

Then, we could work among the alpha end and beta releases in:
- Performance Issues.
- Full testing.
- Bugs.

Please create all issues that you think we need, It's easy to review more little things that all module change code, if we can.

Now I'm going to review again all issue queue for better work organization :D

jansete’s picture

jansete commented
Issue summary: View changes
steel-track’s picture

steel-track commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented

A lot of changes I've made this weekend, we are very close to the alpha1, maybe in the next weekend.

The next steps:
- General code review
- Solve this issues:
-- #2856612: S3fsStream always uses the credentials not the profile
-- #2854735: Custom hostname not working in Drupal 8
-- #2811455: Allow ACLs to be overridden
-- #2856566: Getting 0 bytes files when copying from remote
-- #2855626: Aws\S3\Exception\S3Exception: Error executing "GetObject" on s3.amazonaws when image not exists.
- Update README.txt
- Test, test and test.

In alpha we introduce tests from Drupal 7 and others like:
- #2812749: IAM Credentials usage
- #2828403: s3fs module does not validate that the acess key + secret key has the permissions to put/upload the file into the bucket

jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
jansete’s picture

jansete commented
Issue summary: View changes
nesimo’s picture

nesimo commented

great work

jansete’s picture

jansete commented
Status: Active » Fixed

We have the first alpha :)

https://www.drupal.org/project/s3fs/releases/8.x-3.0-alpha0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.