There are some errors in coding standard and @file bloc was missing in some of the file.

CommentFileSizeAuthor
#11 fix_coding_standards-2854100-11.patch94.95 KBjstoller
#10 fix_coding_standards-2854100-10.patch94.8 KBjstoller
#9 fix_coding_standards-2854100-9.patch94.8 KBjstoller
#8 fix_coding_standards-2854100-8.patch94.77 KBjstoller
#6 interdiff-2854100-6.txt38.56 KBhgunicamp
#6 fix_coding_standards-2854100-6.patch47.84 KBhgunicamp
#2 coding_standards-2854100-2.patch6.69 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Status: Active » Needs review
StatusFileSize
new coding_standards-2854100-2.patch6.69 KB
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community

@Munavijayalakshmi Thanks for the patch, it works well.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Needs work

The coding standards have changed so that @file docblocks are not needed for files which only contain a single class (or other object definition), instead those should just have a docblock for the class. This specifically affects ParagraphsMigrateParagraphsFieldHandler.inc but might affect others too.

hgunicamp’s picture

hgunicamp commented
Status: Needs work » Needs review
Issue tags: +ciandt-contrib
StatusFileSize
new fix_coding_standards-2854100-6.patch47.84 KB
new interdiff-2854100-6.txt38.56 KB

I'm posting a new patch.

I removed the '@file' statement from 'ParagraphsItemMetadataController.inc', 'views/paragraphs_handler_relationship.inc', 'ParagraphsItemEntity.inc', 'migrate/destinations/MigrateDestinationParagraphsItem.inc', 'migrate/fields/ParagraphsMigrateParagraphsFieldHandler.inc' and 'plugins/panelizer/entity/PanelizerEntityParagraphsItem.class.php'.

I also used phpcbf to make some automatic fixes that were not covered by the previous patch.

Algarte’s picture

Algarte commented
Status: Needs review » Reviewed & tested by the community

I've applied the patch #6 on a clean drupal environment and ran coder to verify any other issues, there are some that can be fixed by someone with more knowledge on this module, like adding parameter and return type to some files and adding a short description for some functions. Other than that, this patch works fine for me.

jstoller’s picture

jstoller
he/him
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new fix_coding_standards-2854100-8.patch94.77 KB

Updated and expanded to work with the latest dev. If this passes I'll commit it tonight.

jstoller’s picture

jstoller
he/him
commented
Assigned: Unassigned » jstoller
StatusFileSize
new fix_coding_standards-2854100-9.patch94.8 KB
jstoller’s picture

jstoller
he/him
commented
StatusFileSize
new fix_coding_standards-2854100-10.patch94.8 KB
jstoller’s picture

jstoller
he/him
commented
StatusFileSize
new fix_coding_standards-2854100-11.patch94.95 KB

See, this is what happens when I get cocky. 😒

  • jstoller committed 2d5fabb on 7.x-1.x 
    Issue #2854100 by jstoller, hgunicamp, Munavijayalakshmi, riddhi.addweb...
jstoller’s picture

jstoller
he/him
commented
Assigned: jstoller » Unassigned
Status: Needs review » Fixed

Patch pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.