Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are some errors in coding standard and @file bloc was missing in some of the file.
Comment | File | Size | Author |
---|---|---|---|
#11 | fix_coding_standards-2854100-11.patch | 94.95 KB | jstoller |
| |||
#2 | coding_standards-2854100-2.patch | 6.69 KB | Munavijayalakshmi |
|
Comments
Comment #2
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commentedComment #3
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented@Munavijayalakshmi Thanks for the patch, it works well.
Comment #4
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commentedComment #5
DamienMcKennaThe coding standards have changed so that @file docblocks are not needed for files which only contain a single class (or other object definition), instead those should just have a docblock for the class. This specifically affects ParagraphsMigrateParagraphsFieldHandler.inc but might affect others too.
Comment #6
hgunicamp CreditAttribution: hgunicamp at CI&T commentedI'm posting a new patch.
I removed the '@file' statement from 'ParagraphsItemMetadataController.inc', 'views/paragraphs_handler_relationship.inc', 'ParagraphsItemEntity.inc', 'migrate/destinations/MigrateDestinationParagraphsItem.inc', 'migrate/fields/ParagraphsMigrateParagraphsFieldHandler.inc' and 'plugins/panelizer/entity/PanelizerEntityParagraphsItem.class.php'.
I also used phpcbf to make some automatic fixes that were not covered by the previous patch.
Comment #7
Algarte CreditAttribution: Algarte commentedI've applied the patch #6 on a clean drupal environment and ran coder to verify any other issues, there are some that can be fixed by someone with more knowledge on this module, like adding parameter and return type to some files and adding a short description for some functions. Other than that, this patch works fine for me.
Comment #8
jstollerUpdated and expanded to work with the latest dev. If this passes I'll commit it tonight.
Comment #9
jstollerComment #10
jstollerComment #11
jstollerSee, this is what happens when I get cocky. 😒
Comment #13
jstollerPatch pushed to dev.