Set as current revision instead reverts [#2854057]

When I try to set the current revision via the moderation tab I can only revert.

Steps to reproduce:
- When I create a landing page and publish.
- Create a new revision in draft mode.
- go to revisions tab
- click "Set as current revision"
- Taken to a page that instead asks about reverting the current revision

Comment	File	Size	Author
	Screen Shot 2017-02-19 at 9.27.21 PM.png	173.32 KB	adam.weingarten
	Screen Shot 2017-02-19 at 9.27.13 PM.png	376.25 KB	adam.weingarten

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 February 2017 at 02:32

adam.weingarten created an issue. See original summary.

Comment #2

balsama

he/him

English

boston

CreditAttribution: balsama at Acquia commented 22 February 2017 at 14:33

Interesting. I don't think this has been reported before.

Is this really just a problem with the verb not changing when the revision you are setting as default happens to be newer than the current default? I suspect "revert" is hardcoded and really means "switch". But I haven't tested that.

Comment #3

balsama

he/him

English

boston

CreditAttribution: balsama at Acquia commented 28 February 2017 at 14:02

@phenaproxima suggests overriding the title callback to change the wording so it makes sense for newer and older.

Comment #4

phenaproxima

he/him

English

Massachusetts

CreditAttribution: phenaproxima at Acquia commented 6 March 2017 at 18:38

Status:

Active

» Needs review

Pull request created: https://github.com/acquia/lightning/pull/285

Comment #5

balsama

he/him

English

boston

CreditAttribution: balsama at Acquia commented 6 March 2017 at 18:58

Found a bug when testing this...

If you follow the steps in the original issue, the expected result is:
* Forward revision is set as default revision
* Default revision is unpublished
* Six total revisions remain (image in IS shows six)

Actual results
* Default revision remains unchanged
* New forward revision created that is a clone of the forward revision we wanted to make default

The STR are somewhat of an edge case. The accepted way to do this (un-publish the current revision) is to set the published entities workflow state to archived. So I'd be OK with just removing the option to "set as current revision" if the revision is forward. But I can also imagine some workflows that really want to be able to do this. (I might want to un-publish something and make all other editors see a specific draft when they visit the entity in the same action, for example.)