Determination of derivative is needed only once, don't call each time

CommentFileSizeAuthor
#2 derivative-useless.patch697 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new derivative-useless.patch697 bytes
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Needs review » Reviewed & tested by the community

Patch applies, the logic makes total sense. This is an easy win.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Do not call derivative without need » Only call getDerivativeId() when needed

  • Gábor Hojtsy committed f627c18 on 8.3.x 
    Issue #2854046 by andypost: Only call getDerivativeId() when needed

(...

  • Gábor Hojtsy committed a1d257f on 8.4.x 
    Issue #2854046 by andypost: Only call getDerivativeId() when needed
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Makes sense, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.