The doc block should read Provides test data for testUserNameAccess() instead of Provides test data for estUserNameAccess()

CommentFileSizeAuthor
#2 typo_in_docblock-2854012-1.patch599 bytesvegantriathlete

Comments

vegantriathlete created an issue. See original summary.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
StatusFileSize
new typo_in_docblock-2854012-1.patch599 bytes

Patch attached!

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Status: Active » Needs review
krina.addweb’s picture

krina.addweb commented
Status: Needs review » Reviewed & tested by the community

@vegantriathlete,Thanks for the corrections it works well.

  • xjm committed 182edb2 on 8.4.x 
    Issue #2854012 by vegantriathlete: Typo in Doc block for data provider
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.2.6 » 8.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Alright, our automated standards checking or a spellcheck won't necessarily catch this. Committed to 8.4.x and 8.3.x. Thanks for the cleanup!

krina.addweb’s picture

krina.addweb commented

@xjm,I guess you forgot to provide me RTBC credit, can you please do the needful.

  • xjm committed e9358c2 on 8.3.x 
    Issue #2854012 by vegantriathlete: Typo in Doc block for data provider...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Patch (to be ported) » Fixed

This is fixed in both active branches.

@krina.addweb - credit is at committer discretion and generally just rtbc'ing a patch with a comment like

@vegantriathlete,Thanks for the corrections it works well.

In order to get credit you need to provide evidence of how the patch was reviewed and what was considered when setting the patch to rtbc. Some issues like this one - do not require such evidence and consideration so the reviewer is unlikely to get credit.

krina.addweb’s picture

krina.addweb commented

@alexpott, Yes you were right ,but i have to check patch manually by applying it in module & when its a code change how can i take any screenshots,if it refelects in front view i can make it possible.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.