In my work getting aegir driving docker containers, I need to alter the VirtualHost template to always write port 80.

While there is a hook to alter the template used, I found there was no way to alter variables directly, so I made one.

Branch and patch coming.

CommentFileSizeAuthor
#4 2853184-template-vars-alter.patch1.85 KBjon pugh

Comments

Jon Pugh created an issue. See original summary.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Related issues: +#2309547: [meta] Aegir & Docker

  • Jon Pugh committed bcd19f3 on 2853184-template-vars-alter 
    Issue #2853184: In the Provision_Config::render_template() method, add...
jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
StatusFileSize
new 2853184-template-vars-alter.patch1.85 KB
helmo’s picture

helmo commented

15:19 <@helmo> 2853184 looks good apart from a few lines with trailing whitespace ... which editor do you use?
15:22 <@helmo> jonpugh: ^, after drush_command_invoke_all_ref it could use a blank line... rtbc

  • Jon Pugh committed 40264f6 on 2853184-template-vars-alter 
    Issue #2853184: Improve the docblock.

  • Jon Pugh committed 966277c on 2853184-template-vars-alter 
    Issue #2853184: Adding line after hook invoke.

  • helmo committed 71a4de7 on 2853184-template-vars-alter 
    Issue #2853184: Fix whitespace
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

So, this is similar to:

...but it's in core, and you can alter existing variables?

helmo’s picture

helmo commented

This is a bit different ... it's for the variables used in templates.

helmo’s picture

helmo commented
Status: Needs review » Reviewed & tested by the community

  • Jon Pugh committed 40264f6 on 7.x-3.x 
    Issue #2853184: Improve the docblock.
  • helmo committed 71a4de7 on 7.x-3.x
    Issue #2853184: Fix whitespace
  • Jon Pugh committed 966277c on 7.x-3.x
    Issue #2853184: Adding line after hook invoke.
  • helmo committed baaa691 on 7.x-3.x
    Issue #2853184 by Jon Pugh: Merge remote-tracking branch 'origin/2853184...
  • Jon Pugh committed bcd19f3 on 7.x-3.x
    Issue #2853184: In the Provision_Config::render_template() method, add...
helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented
Status: Closed (fixed) » Needs work

This hook needs documentation. Just being in the API file is not enough.

  • Jon Pugh committed 40264f6 on 7.x-4.x 
    Issue #2853184: Improve the docblock.
  • helmo committed 71a4de7 on 7.x-4.x
    Issue #2853184: Fix whitespace
  • Jon Pugh committed 966277c on 7.x-4.x
    Issue #2853184: Adding line after hook invoke.
  • helmo committed baaa691 on 7.x-4.x
    Issue #2853184 by Jon Pugh: Merge remote-tracking branch 'origin/2853184...
  • Jon Pugh committed bcd19f3 on 7.x-4.x
    Issue #2853184: In the Provision_Config::render_template() method, add...