Closed (fixed)
Project:
Drupal core
Version:
8.3.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Feb 2017 at 19:17 UTC
Updated:
8 Mar 2017 at 17:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
xjmThanks @effulgentsia. This is indeed patch-release-eligible since it's a patch-level update.
Comment #3
gnugetHi!
Patch attached.
Comment #4
nod_Looks good to me, changelog is small. Clicking around show things still work.
Comment #5
droplet commentedNeeds to update core.libraries.yml
Comment #6
gnugetduh!
Thanks for your reviews.
New patch attached.
Comment #7
nod_Path to the licence to update too.
Comment #8
gnugetComment #9
kporras07 commentedAttached new patch.
Btw, it looks like the jquery license file previously listed doesn't exist since so much time ago.
Comment #10
swarad07While applying patch, there are warnings about tab indentation. I am assuming we cannot do much about it as it is a vendor js file.
Tab added
Tab added
Tab added
Tab added
Tab added
Tab added
Comment #11
droplet commented@swarad07,
we need not fix the vendor formatting.
Comment #13
gnugetComment #15
xjmThanks everyone for the update and JS review!
After discussing the patch-level update with @wimleers, I think it's best to get this in now and use the RC phase to flush out any bugs that might occur.
Note that the vendor whitespace is correctly skipped by our coding standards checking, so we are good there:
Committed to 8.4.x and cherry-picked to 8.3.x. Thanks!