Add reset button to user name validation form in configuration page, to clear the inputted data

CommentFileSizeAuthor
#8 reset_button-2852493-8.patch1.06 KBdeaom
#7 Screen Shot 2017-03-07 at 4.16.57 PM.png56.29 KBriddhi.addweb
#6 reset_button-2852493-6.patch1.16 KBsneha_surve
#2 resetbutton-2852493-2.patch776 bytesPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Status: Active » Needs review
StatusFileSize
new resetbutton-2852493-2.patch776 bytes

Applying the patch

saradaprasad17’s picture

saradaprasad17 commented
Status: Needs review » Needs work

Reset configuration not working .

saradaprasad17’s picture

saradaprasad17 commented
sneha_surve’s picture

sneha_surve commented
Assigned: Pavan B S » sneha_surve
sneha_surve’s picture

sneha_surve commented
Assigned: sneha_surve » Unassigned
Status: Needs work » Needs review
StatusFileSize
new reset_button-2852493-6.patch1.16 KB
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screen Shot 2017-03-07 at 4.16.57 PM.png56.29 KB

@sneha_surve,Thanks for the patch, i checked it with Simplytest.Me & i've one issue during clear configuration, When i click on Clear Configuration it displays the message for Success.There is no need to display this message.

deaom’s picture

deaom commented
StatusFileSize
new reset_button-2852493-8.patch1.06 KB

Hi, I re-rolled the patch since it did not apply anymore to dev branch and moved the clear configuration from submit function by adding a new function that handles deletion of configuration. Patch is attached.

deaom’s picture

deaom commented
Status: Needs work » Needs review

Changing the tag to needs review.

nace_fr’s picture

nace_fr commented
Status: Needs review » Reviewed & tested by the community

Hi. I have tested patch from #8. It applied successfully and worked as needed. I'm changing status to RTBC. Thanks DeaOm.

  • VladimirAus committed 57f3fab on 8.x-1.x authored by DeaOm 
    Issue #2852493 by Pavan B S, sneha_surve, DeaOm, riddhi.addweb,...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.