Over at #2642122: Overriding already overridden libraries-override requires knowledge of previous libraries-overrides a BC-layer is added to maintain pre-existing behavior of libraries-override
for sub themes of base themes that also have libraries-override
on the same library assets.
The pre-existing behavior as summarized by @jacine #2642122-18: Overriding already overridden libraries-override requires knowledge of previous libraries-overrides is a bug:
And this is the logic:
Use the original module (or core) namespace for library name.
Use the path of the most recent override (in my case Stable) as the key
Use the full path to the file
The correct behavior should be:
Use the original module (or core) namespace for library name.
Use the originally defined library path as the key
Use the relative path to the file in the current theme as the value
This issue is created to remove the BC-layer
Comment | File | Size | Author |
---|---|---|---|
#3 | 2852314-3.patch | 5.39 KB | almaudoh |
#2 | 2852314-2.patch | 4.32 KB | almaudoh |
Comments
Comment #2
almaudoh CreditAttribution: almaudoh commentedAttached the patch for future BC-removal and postponed.
Comment #3
almaudoh CreditAttribution: almaudoh commentedUpdated patch to remove legacy deprecated code.
Comment #5
xjmLooks like this was already addressed in a different issue.
Comment #6
acbramley CreditAttribution: acbramley at PreviousNext commentedThe original fix hasn't been committed yet and therefore the BC layer can't have been removed yet. I think the confusion is from the version this issue was against?