Problem/Motivation

#2824655: Plugin definitions should store their class in a consistent manner (without leading slashes) made all plugin definitions store their class in a consistent manner, without a leading slash.
That way when compared to the ::class constant, it would match.

This was a change that needed no updates to any plugin types except TypedConfigManager, so a workaround was added

Proposed resolution

Remove the workaround

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
9.96 KB

Turns out it was easier than I thought before, could have been part of that issue.
AFAICS it's just this one test.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

There are unneeded changes in test file but It is assuring to see that we have test coverage for this.

tim.plunkett’s picture

The switch to ::class is needed, or at least removing the leading slash from the string. Same thing

  • effulgentsia committed 2b2f939 on 8.4.x
    Issue #2851600 by tim.plunkett, jibran: Remove workaround from \Drupal\...

  • effulgentsia committed a0cb58c on 8.3.x
    Issue #2851600 by tim.plunkett, jibran: Remove workaround from \Drupal\...
effulgentsia’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks! Pushed to 8.4.x and cherry picked to 8.3.x. Also added this as a referenced issue in the existing CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.