There are a few coding standards issues with this file.
http://cgit.drupalcode.org/aws_sqs/tree/src/Form/AwsSqsSettingsForm.php?...

A few places where there is no space after if(), such as if ()
Should use 2 spaces for tabs instead of 4
Instead of just t() like in D6, D8 should use $this->t()

CommentFileSizeAuthor
#4 placeholder_format-coding_standards-2851292-2851283.patch14.18 KBjoshua.boltz
#2 coding_standards-2851292-1.patch14.18 KBjoshua.boltz

Comments

joshua.boltz created an issue. See original summary.

joshua.boltz’s picture

joshua.boltz commented
StatusFileSize
new coding_standards-2851292-1.patch14.18 KB

Patch attached to address coding standards.

Mostly related to 2 vs. 4 space.
A few places where there was a missing space after if() conditional, changed to if ()
Use of $this->t() instead of just t(), which was how it was done in D7

https://www.drupal.org/docs/develop/standards/coding-standards

joshua.boltz’s picture

joshua.boltz commented
Status: Active » Needs review
joshua.boltz’s picture

joshua.boltz commented
Status: Needs review » Active
StatusFileSize
new placeholder_format-coding_standards-2851292-2851283.patch14.18 KB

Added patch that combines the coding standards patch found in this issue with the patch contained at https://www.drupal.org/node/2851283

bunty badgujar’s picture

bunty badgujar commented
Assigned: Unassigned » bunty badgujar
bunty badgujar’s picture

bunty badgujar commented
Status: Active » Fixed
bunty badgujar’s picture

bunty badgujar commented
Status: Fixed » Closed (fixed)