I hate to have to do this, but the hook is messing with cache contexts, views and grants and it could potentially lead to an information disclosure security hole.

For full info, see: #2796197-24: Group or Group Node generates some massive queries

Steps to take:

  1. Remove the hook and all traces of it
  2. Mark the Group role sync module as experimental and make it do nothing for the time being
  3. Investigate whether we need an update hook to clean up after the module or whether we can leave its roles in the DB for the time being
  4. Provide a change record
CommentFileSizeAuthor
#2 group-2850417-2.patch12.15 KBkristiaanvandeneynde
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Deeson commented
Status: Active » Needs review
FileSize
group-2850417-2.patch12.15 KB

This patch should neutralize the module for the time being. I'll write down a plan next.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Deeson commented

See #2852232: Implement a means of role synchronization for a way to replace the Group Role Sync module.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Deeson commented
Status: Needs review » Fixed

Marking this as fixed so we can release a new beta. The next release will contain a working alternative to this module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.