Remove documentation references to deprecated function menu_local_tasks()

@joachim
Please, could you add more details about what should be done in this issue?

Found that \Drupal\Core\Menu\LocalTaskManager::getLocalTasks() invokes this. Changed the documentation. Please review.

There are several more docs references to this deprecated function that we should fix in the same patch:

[ibnsina:drupal | Sat 17:56:38] $ grep -r "menu_local_tasks" * | grep "\*"
core/includes/menu.inc: * @see hook_menu_local_tasks_alter()
core/lib/Drupal/Core/Menu/LocalTaskManagerInterface.php:   * @see hook_menu_local_tasks_alter()
core/lib/Drupal/Core/Menu/menu.api.php: * hook_menu_local_tasks_alter().
core/lib/Drupal/Core/Menu/menu.api.php: * This hook is invoked by menu_local_tasks(). The system-determined tabs and
core/modules/contact/contact.module: * Implements hook_menu_local_tasks_alter().
core/modules/system/tests/modules/menu_test/menu_test.module: * Implements hook_menu_local_tasks_alter().
core/modules/views_ui/src/ViewFormBase.php:   * This function can be called from hook_menu_local_tasks_alter() to implement

For background information on why we should correct them all at once, see https://www.drupal.org/core/scope.

Thanks for working on this!

As a documentation fix only, the scope I've set can also be backported to 8.3.x.

The one replaced in #7 looks like the only one.

tameeshb@imt3rabyt3 /v/w/h/drupal83> grep -r 'menu_local_tasks()' .
./core/lib/Drupal/Core/Menu/menu.api.php: * This hook is invoked by menu_local_tasks(). The system-determined tabs and
tameeshb@imt3rabyt3 /v/w/h/drupal83> 

RTBC?

Note that grepping for menu_local_tasks() with closed parens is not sufficient, because the function call may be documented with arguments, in which case the parentheses may be separated, or as a callback, meaning no parentheses. So the remaining ones not caught by the grep in #11 are these:

core/includes/menu.inc:    '#theme' => 'menu_local_tasks',
core/includes/theme.inc:    'menu_local_tasks' => array(
core/lib/Drupal/Core/Menu/Plugin/Block/LocalTasksBlock.php:      '#theme' => 'menu_local_tasks',

However, those are not actually documentation references. So indeed, the current patch works for the extended scope. Thanks for double-checking and sorry for the extra review!

We probably need a followup though to actually remove the places where it's being used as a theme function, so tagging for that.

By the way, for some info on how we will be changing our process on deprecation in the future, see:

• #2822727: [policy, no patch] Adopt a continuous API upgrade path for major version changes
• #2575081: [policy, no patch] Use E_USER_DEPRECATED in Drupal 8 minor releases
• #2488860: Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation

We will also require full removals in advance of Drupal 9:
#2607260: [meta] Core deprecation message introduction, contrib testing etc.

@xjm, I had thought of the params so I also grepped using, "menu_local_tasks(" but didn't know about the callback part without any parentheses, thanks :D