Patch in #2530904: Unknown package version in Drupal 7 made _provision_drupal_find_themes() function read version key from discovered themes:

$files[$name]->version = $files[$name]->info['version'];

This code, however, assumes that this key is always present in *.info file of a theme. But this is not true for custom themes or themes installed by clonning Git repositories.

This is a minor problem but it will still appear in the logs which is not good.

CommentFileSizeAuthor
#3 2849593-3__7.x-4.x.patch889 bytes20th
#2 2849593-1__7.x-3.x.patch928 bytes20th
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

20th created an issue. See original summary.

20th’s picture

Status: Active » Needs review
FileSize
928 bytes

Before accessing version element of the info array, the code should check that this element exists.

If it does not exist, theme version should be set to NULL, this way the version will be correctly displayed as Unknown in the list of platform packages in the UI.

20th’s picture

The patch from #2 applies only to branch 7.x-3.x.

The 7.x-4.x branch is not affected by this error because it does not have the same line of code. It looks like the patch from #2530904: Unknown package version in Drupal 7 was committed only to one of the branches.

Uploading different patch for 7.x-4.x branch because it would probably be better to add this functionality there as well.

  • helmo committed f4718d3 on 7.x-3.x authored by 20th
    Issue #2849593 by 20th: Undefined index: version in packages_7.inc
    
helmo’s picture

Status: Needs review » Fixed

Thanks, committed.

Don't worry about the 4.x branch ... It's way behind 3.x and currently more a placeholder for issue management.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.