I wanted to have a default starting value and I saw the TODO in the code, I have added code as part of field settings so it can be modified later easily and also can be part of field instance (and not field base).

CommentFileSizeAuthor
#10 interdiff_7-10.txt584 bytescolorfield
#10 2847954-starting_value_init_existing-10.patch7.39 KBcolorfield
#10 serial-no-entities-init.png.png7.32 KBcolorfield
#7 serial-no-entities-to-init.png7.54 KBcolorfield
#7 serial-storage-existing-data.png30.08 KBcolorfield
#7 serial-init-confirmation.png12.44 KBcolorfield
#7 serial-storage-settings.png34.32 KBcolorfield
#7 2847954-starting_value_init_existing-7.patch7.39 KBcolorfield
#4 After_patch.PNG47.14 KBTruptti
#4 Before_patch.PNG48.21 KBTruptti
#2 allow_having_starting-2847954-2.patch2.39 KBnikunjkotecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nikunjkotecha created an issue. See original summary.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and at Axelerant commented
FileSize
allow_having_starting-2847954-2.patch2.39 KB
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and at Axelerant commented
Status: Active » Needs review
Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
FileSize
Before_patch.PNG48.21 KB
After_patch.PNG47.14 KB

Verified the patch 'allow_having_starting-2847954-2.patch' on Drupal 8.x-1.x, below are the observations
Before Patch :
1.The serial module does not have configuration settings to set the Starting Value
After Patch
1.The serial module have the configuration settings where user could set the Starting Value.
Attaching snapshot Before_Patch.png and After_Patch.png for reference.

Pavan B S’s picture

Pavan B S CreditAttribution: Pavan B S at Valuebound commented
Assigned: Unassigned » Pavan B S
Status: Needs review » Reviewed & tested by the community

Thanks for the patch ,it is working fine

jo1ene’s picture

jo1ene CreditAttribution: jo1ene commented

This works well. One issue though is that it does not start on the number set, but the next number.

colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented
FileSize
2847954-starting_value_init_existing-7.patch7.39 KB
serial-storage-settings.png34.32 KB
serial-init-confirmation.png12.44 KB
serial-storage-existing-data.png30.08 KB
serial-no-entities-to-init.png7.54 KB

Thanks for looking into this, it is really useful and should be considered with the current behavior of initializing existing entities by default.

SerialSQLStorage::initOldEntries() is executed when the field is created. So, currently, if we have existing entities for a bundle, the behavior is that initOldEntries() is automatically executed and assigns serials from 1 to n (amount of existing entities), then we are not able to set the desired starting value anymore.

So I propose to defer the execution of initOldEntries(), with a flag that allows the site builder to also choose if the initialization must happen.

As the two settings might not change after the field creation, we should use storageSettingsForm instead of fieldSettingsForm.

The patch produces this behavior:

Storage settings
Storage settings

Initialization confirmation
Existing entities
Initialisation confirmation
No existing entities
No existing entities to init

Storage settings disabled when data exists for this field
Storage settings with existing data

colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented
Title: Allow having starting value for the serial field. » Allow having starting value for the serial field and set existing entities initialization as optional
Status: Reviewed & tested by the community » Needs review
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented

This looks amazing, I'll give it a try.

colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented
Issue summary: View changes
FileSize
serial-no-entities-init.png.png7.32 KB
2847954-starting_value_init_existing-10.patch7.39 KB
interdiff_7-10.txt584 bytes

Thank you @nikunjkotecha! Noticed a small typo, updated the patch (Not -> No).

No existing entities to init

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and at QED42 commented
Assigned: Pavan B S » Unassigned
Status: Needs review » Reviewed & tested by the community

Works as described.

caspervoogt’s picture

caspervoogt CreditAttribution: caspervoogt at Plethora commented

patch from #10 works.

ShutterFreak’s picture

ShutterFreak CreditAttribution: ShutterFreak as a volunteer commented

Please note that, once you identified the correct table, you can use PHPMyAdmin to set the AUTO-INCREMENT value for the table to the next value to be used. Ideally the module would offer the option to adjust / re-number the serial sequence for existing nodes, e.g. by providing sorting mechanisms (or through Ctools and VBO).

colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented

Thanks @ShutterFreak, with this patch it should not be necessary to alter the database manually.
Re-numbering might be another issue, feel free to create a new one for this use case.

  • colorfield committed 05ebda2 on 8.x-1.x 
    Issue #2847954 by colorfield, nikunjkotecha, Truptti, Pavan B S, jo1ene...
colorfield’s picture

colorfield
Primary language French
Location Lausanne
CreditAttribution: colorfield as a volunteer and at Amazee Labs commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.