As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#2 remove@file_2847944_1.patch432 bytesnehakhadke

Issue fork views_photo_grid-2847944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new remove@file_2847944_1.patch432 bytes
urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora
urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Reviewed & tested by the community

Hi,
I reviewed your patch. It applied cleanly.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/views_photo_grid-2847944$ git apply -v remove@file_2847944_1.patch
Checking patch src/Plugin/views/style/PhotoGrid.php...
Applied patch src/Plugin/views/style/PhotoGrid.php cleanly.

Thanks, I am moving it to RTBC and creating a MR.

urvashi_vora opened merge request !2

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned

glekli made their first commit to this issue’s fork.

glekli’s picture

glekli commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.