In #2779641: Provide method to store user's picture, there were calls added to drupalSetMessage in SocialAuthUserManager, but there is no such method. It was not found easily because they were executed in edge cases. One such case is filed here: #2847914: Attempts to create an user even if it already exists. I improved the logic to remove unnecessary calls to createUser in that issue, but the problem still remains. If the user exists and attempted to be created anyway, we hit this fatal error.
Remove the calls to the said method.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fatal_error-2847918-2.patch | 1.24 KB | hussainweb |
Comments
Comment #2
hussainwebReplacing the method with the actual function call. Since we call it only from two places, creating a method seems an overkill for now.
Comment #3
himanshu-dixit commentedBulkForm::drupalSetMessage do exist but i don't think we are using it here. IMHO we could use simple drupal_set_message instead https://api.drupal.org/api/drupal/core!modules!system!src!Plugin!views!f... . The Patch Looks good to me
Comment #4
hussainwebThanks! I just want to point out that that BulkForm class is entirely unrelated to this. It is not like we could reuse that method even if we wanted to. And yes, since it is only two calls, it is simpler to just use drupal_set_message.
Comment #6
gvsoThanks!