Unfortunately there was no option for a custom marker icon.

I've created a patch that made it possible to set a relative/absolute path to a custom marker for de views style 'CommonMap' and 'GoogleMapsFormatter'.

Needs review!

CommentFileSizeAuthor
#21 2847748-21-move-marker-path-to-google-settings.patch13.62 KBchristianadamski
#19 2847748-19-move-marker-path-to-google-settings.patch13.6 KBchristianadamski
#17 2847748-16-move-marker-path-to-google-settings.patch13.1 KBchristianadamski
#10 interdiff-2847748-7-10.txt2.45 KBdietr_ch
#10 settings-to-set-path-marker-icon-2847748-10.patch5.64 KBdietr_ch
#7 settings-to-set-path-marker-icon.patch6.55 KBjeroendegloire
#5 settings-to-set-path-marker-icon.patch5.88 KBjeroendegloire
#2 settings-to-set-path-marker-icon.patch4.33 KBjeroendegloire

Comments

jeroendegloire created an issue. See original summary.

jeroendegloire’s picture

jeroendegloire commented
StatusFileSize
new settings-to-set-path-marker-icon.patch4.33 KB
jeroendegloire’s picture

jeroendegloire commented
Component: Google Maps geolocation » User interface

Status: Needs review » Needs work

The last submitted patch, 2: settings-to-set-path-marker-icon.patch, failed testing.

jeroendegloire’s picture

jeroendegloire commented
Issue summary: View changes
StatusFileSize
new settings-to-set-path-marker-icon.patch5.88 KB
christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
jeroendegloire’s picture

jeroendegloire commented
StatusFileSize
new settings-to-set-path-marker-icon.patch6.55 KB

Status: Needs review » Needs work

The last submitted patch, 7: settings-to-set-path-marker-icon.patch, failed testing.

berdyshev’s picture

berdyshev commented

Tested with views — works good.
It would be nice to have such option for Google Maps widget too

dietr_ch’s picture

dietr_ch commented
Status: Needs work » Needs review
StatusFileSize
new settings-to-set-path-marker-icon-2847748-10.patch5.64 KB
new interdiff-2847748-7-10.txt2.45 KB

Hi

I altered the patch in #7 to remove the change on the default bubble title/content. This should be a separate issue (there is for example #2847105). I also made a few slight syntax changes.

Dietrich

berdyshev’s picture

berdyshev commented

Nice. 

+++ b/src/Plugin/Field/FieldFormatter/GeolocationGoogleMapFormatter.php
@@ -265,4 +264,4 @@ class GeolocationGoogleMapFormatter extends FormatterBase {
\ No newline at end of file

missing newline at end of file

Status: Needs review » Needs work

The last submitted patch, 10: settings-to-set-path-marker-icon-2847748-10.patch, failed testing.

dietr_ch’s picture

dietr_ch commented
Status: Needs work » Needs review

Just re-queued the patch for testing. I am unsure whether the failures on PHP 5.5 and 5.6 have anything to do with the patch.

@berdyshev: the trailing newline in my updated patch was added automatically by vim (which hides it). Not sure whether it is specified in coding standards.

Status: Needs review » Needs work

The last submitted patch, 10: settings-to-set-path-marker-icon-2847748-10.patch, failed testing.

christianadamski’s picture

christianadamski commented

Wouldn't it be more useful to add this to the generic GoogleMapSettings?

christianadamski’s picture

christianadamski commented

Generalized icon path and moved to GoogleMapSettings. Also fixed two other more or less unrelated issues along the way.

christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 2847748-16-move-marker-path-to-google-settings.patch13.1 KB

Status: Needs review » Needs work

The last submitted patch, 17: 2847748-16-move-marker-path-to-google-settings.patch, failed testing.

christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 2847748-19-move-marker-path-to-google-settings.patch13.6 KB

Added schema entry

Status: Needs review » Needs work

The last submitted patch, 19: 2847748-19-move-marker-path-to-google-settings.patch, failed testing.

christianadamski’s picture

christianadamski commented
Status: Needs work » Needs review
StatusFileSize
new 2847748-21-move-marker-path-to-google-settings.patch13.62 KB

Added explicite string type check

The last submitted patch, 19: 2847748-19-move-marker-path-to-google-settings.patch, failed testing.

  • ChristianAdamski authored 7e8a8f7 on 8.x-1.x 
    Issue #2847748 by jeroendegloire, ChristianAdamski, dietr_ch: Setting...
christianadamski’s picture

christianadamski commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.