By default, the user roles config is set to include the listed roles. When you load the config form all roles are checked yet in the config, this doesn't match as there are no user roles added until the form is saved.

To simplify this and to be consistent with Drupal standard behaviour, user roles should be exclusive with none selected.

CommentFileSizeAuthor
#6 interdiff.txt1.03 KBkmoll
#6 2847463-default-roles-to-unchecked--6.patch1.55 KBkmoll
#3 2847463-default-roles-to-unchecked-3.patch749 byteskmoll

Comments

badjava created an issue. See original summary.

kmoll’s picture

kmoll commented
Assigned: badjava » kmoll
kmoll’s picture

kmoll commented
StatusFileSize
new 2847463-default-roles-to-unchecked-3.patch749 bytes

Yes, the form should reflect what roles have been enabled. If there is no roles in the config, the form should not show those as checked.

kmoll’s picture

kmoll commented
Status: Active » Needs review
badjava’s picture

badjava commented

Looks good although I think the default for role tracking type should be set to exclusive, not inclusive to minimise the configuration required. This would enable tracking by default for all roles. It would also allow new roles to be created and automatically tracked without having to update the Adobe Analytics configuration settings.

kmoll’s picture

kmoll commented
StatusFileSize
new 2847463-default-roles-to-unchecked--6.patch1.55 KB
new interdiff.txt1.03 KB

Updated patch

badjava’s picture

badjava commented
Status: Needs review » Reviewed & tested by the community

Looks good - RTBC.

  • kmoll committed 2f0598a on 8.x-1.x 
    Issue #2847463 by kmoll, badjava: Config for user roles confusing and...
kmoll’s picture

kmoll commented
Status: Reviewed & tested by the community » Needs review

committed thanks!

kmoll’s picture

kmoll commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.