I converted the code to run on D8 but obviously the filter conditions need to be rewritten as well, based on node_field_data table because the node.tnid field is not there anymore.
I was wondering if the maintainers could create a 8.x-1.x branch with the latest 7.x code in it?
This way I can port things incrementally and share the work on the official repository.
I pushed a first version of the working module.
All the steps can be followed in the git history.
Please note that for now I disabled the include_content_without_translation option, quoting from the commit message:
The "include_content_without_translation" option has been disabled for
now, because there is no immediate way in drupal 8 to characterize
content without translations, and maybe it does not even make sense.
Any opinion on that? I'd like to discuss that before closing this issue.
Comments
Comment #2
ao2 commentedOK, I started looking at the issue myself.
I converted the code to run on D8 but obviously the filter conditions need to be rewritten as well, based on
node_field_datatable because thenode.tnidfield is not there anymore.I was wondering if the maintainers could create a 8.x-1.x branch with the latest 7.x code in it?
This way I can port things incrementally and share the work on the official repository.
Thanks,
Antonio
Comment #3
ao2 commentedHi,
I have the module working on Drupal 8, how should I publish it?
Can I have permissions to create the 8.x-1.x branch myself on the official repository?
Or do you prefer that I publish the changes somewhere else for the maintainers to review them before giving me direct access?
Thanks,
Antonio
Comment #4
alcroito commentedHi,
I've granted you permissions for the project.
You can create a 8.x branch and push the code.
Regards.
Comment #5
ao2 commented@Placinta, thanks!
I pushed a first version of the working module.
All the steps can be followed in the git history.
Please note that for now I disabled the
include_content_without_translationoption, quoting from the commit message:Any opinion on that? I'd like to discuss that before closing this issue.
Thanks,
Antonio
Comment #6
ao2 commentedComment #7
ao2 commentedClosing, the 8.x-1.x branch now contains a version of the module which works on drupal 8.