active-trail not added to parent of is-active item

HI. drupal8 have "menuparent" class

I don't actually see an 'active' class being added to any menu items at all.
I do see a 'menuparent' being applied to items that have sub-items but these are also getting the 'menu-item--expanded' class even when they are not expanded.

Slight correction. An "is-active" class gets added to my front page menu item link. No other menu items get an "is-active" class. My theme has nothing overriding anything remotely menu-related. I have tried it with Bartik as well - same thing.

I can confirm the issue.

menu-parent means that the menuitem has childrens ... not that it's active.
is-active is only set on the anchor tag.

Looking at the core's menu block i made a patch to get the active trail. Now the class .menu-item--active-trail is added like in other menus.

Attention: With this patch the menu is only autoexpanded to the current path, no longer everything! You need to expand the menu items yourself at the moment.

Is there a reason why nice_menus uses the toolbar.menu_tree service and not the menu.link_tree service like cores' does ? This could be adapted as well.

Here another simplified approach, with every item expanded (like it was before).

Here the final patch also respecting caching !

Also removing the rendering in build(), we can leave that to twig.

I just tried the patch from #7 but there is a caching problem. When I rebuild the cache and visit a page which is linked in the menu, then the visited menu item always has the class "menu-item--active-trail". When I click on other menu items, the class still belongs to the menu item, which was visited first after cache rebuild.

I cannot reproduce this behavior. What cache are you using ?

I have enabled page_cache and dynamic_page_cache, running drupal 8.4.3 and also below ..

.menu-item--active-trail is appended to the active menu entry (li tag) and every parent of it.
.is-active is appended only to the active menu entry (a tag).

Thanks ytsurk

i have added a default config.

Thanks patch in #7 worked great for me (from 8.x-1.0-beta2).