Problem/Motivation

#2796173: Add experimental Field Layout module to allow entity view/form modes to switch between layouts allows for rearranging fields on entity form and entity view.
Entity forms use #group, which allows the array structure to remain unchanged, while rendering them into the regions.

That is only available to forms, not general render arrays.

Because of this, Entity view directly alters the array structure.
This increases the chances of contrib or custom code later trying to access the original location, resulting in broken functionality and possibly PHP notices.

Proposed resolution

The most straight-forward and robust solution would be to expand #group to work for all render arrays, which has an existing issue:
#2190333: Make #group FAPI / render feature work on all form/render #types out of the box

Should that prove too complex, consider trying something specific to entity rendering, or something on the preprocess level.

Or, this could be decided as something not worth fixing.

Remaining tasks

Decide what to do:

  1. Postpone on generic #group issue, #2190333: Make #group FAPI / render feature work on all form/render #types out of the box
  2. Develop new approach
  3. Close (won't fix)

User interface changes

N/A

API changes

TBD

Data model changes

N/A

Comments

tim.plunkett created an issue. See original summary.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Yeah it's really a very very important issue to keep the array / field structure unchanged when using regions. +1 for this issue and plan.
We just ran exactly into this issue and discussion.

How can we help to proceed?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Perhaps a secondary feature might be to add an option "Disabled" to use the default node structure without layouts for view modes?

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Any updates to this topic? The layout system is pracitcly useless because of this ...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

No update that I know of.

Someone needs to do the work.

See the proposed resolution and remaining tasks above.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Component: layout.module » field_layout.module

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: Investigate alternative approaches to moving fields in FieldLayoutBuilder::buildView() » [PP-1] Investigate alternative approaches to moving fields in FieldLayoutBuilder::buildView()
Status: Active » Postponed

There's a working patch now in #2190333: Make #group FAPI / render feature work on all form/render #types out of the box, so we should postpone this one as suggested.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Issue summary: View changes

Just adding postponed issue to the remaining tasks.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented

The Field Layout Module was approved for removal in #3007167: [policy] Deprecate field_layout module and move it to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3517712: [meta] Tasks to deprecate the Field Layout module and the removal work in #3517716: [meta] Tasks to remove Field Layout module.

Field Layout will be moved to a contributed project after the Drupal 12.x branch is open.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Project: Drupal core » Field Layout (core)
Version: main » 2.x-dev
Component: field_layout.module » Code
quietone’s picture

quietone commented
Parent issue: #2795833: [plan] Add layouts to entity displays (both form and view) »
Related issues: +#2795833: [plan] Add layouts to entity displays (both form and view)