Problem/Motivation

Markers are hidden behind other markers if multiple markers are based on the same address and therefore cannot be clicked on.

Proposed resolution

By implementing Overlapping Marker Spiderfier this problem would be solved.

Remaining tasks

  • Write a patch that implements Overlapping Marker Spiderfier
  • Wait for #2837983: Render map regardless of results to be ported and committed to Drupal 8 and write a new patch based on these changes
  • Support Marker clusterer extension
  • Review

User interface changes

Settings of the Overlapping Marker Spiderfier will be added to the view settings form.
When enabled, markers will be spiderfied on the view results map.

API changes

For this to work, we need our javascript files in a specific order:

  • Google maps API
  • Overlapping Marker Spiderfier
  • Styled Google Maps

To achieve this order the Google maps API will have to become a library of it's own instead of being loaded by the "styled-google-map" library.

CommentFileSizeAuthor
#9 styled_google_map-overlapping_marker_spiderfier-2845939-9-d8.patch21.81 KBSyndz
#8 styled_google_map-overlapping_marker_spiderfier-2845939-8-d8.patch21.92 KBSyndz
#7 styled_google_map-overlapping_marker_spiderfier-2845939-7-d8.patch21.92 KBSyndz
#4 styled_google_map-overlapping_marker_spiderfier-2845939-4-d8.patch21.54 KBSyndz
#3 styled_google_map-overlapping_marker_spiderfier-2845939-3-d8.patch21.81 KBSyndz

Comments

Syndz created an issue. See original summary.

Syndz’s picture

Syndz commented
Assigned: Syndz » Unassigned
Status: Active » Needs review
Related issues: +#2837983: Render map regardless of results

Here's a patch based on changes in #2837983: Render map regardless of results.

All Overlapping Marker Spiderfier settings can be configured in the view settings.

Does not yet work with all situations of marker clusterer extension.

Syndz’s picture

Syndz commented
Issue summary: View changes
StatusFileSize
new styled_google_map-overlapping_marker_spiderfier-2845939-3-d8.patch21.81 KB

Actually added the patch... :)

Syndz’s picture

Syndz commented
StatusFileSize
new styled_google_map-overlapping_marker_spiderfier-2845939-4-d8.patch21.54 KB

Changed the library's url to be //jawj.github.io instead of //jawj.github.com to prevent mixed content over https

Syndz’s picture

Syndz commented
Syndz’s picture

Syndz commented
Issue summary: View changes
Syndz’s picture

Syndz commented
StatusFileSize
new styled_google_map-overlapping_marker_spiderfier-2845939-7-d8.patch21.92 KB

Same as #4, fixed line endings

Syndz’s picture

Syndz commented
StatusFileSize
new styled_google_map-overlapping_marker_spiderfier-2845939-8-d8.patch21.92 KB

Another try at fixing the line endings

Syndz’s picture

Syndz commented
StatusFileSize
new styled_google_map-overlapping_marker_spiderfier-2845939-9-d8.patch21.81 KB

Last try at fixing the line endings

  • a.dmitriiev committed 45df44f on 8.x-2.x 
    Issue #2845939:  Markers on the same geographic location are hidden...
a.dmitriiev’s picture

a.dmitriiev commented

Thanks for patch. Since then there were couple of changes in the code, so I applied the patch partly. Please check the latest dev version.

a.dmitriiev credited majid.ali.

a.dmitriiev’s picture

a.dmitriiev commented
a.dmitriiev’s picture

a.dmitriiev commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.