CommentFileSizeAuthor
#2 photos_2845822_1.patch45.15 KBnehakhadke

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke commented
StatusFileSize
new photos_2845822_1.patch45.15 KB
nehakhadke’s picture

nehakhadke commented
nathaniel’s picture

nathaniel commented
Status: Needs review » Needs work
Related issues: +#2850882: Cleanup and refactoring

Thank you for the patch and effort. After applying the patch I am experiencing errors. For example:

The website encountered an unexpected error. Please try again later.
Error: Call to undefined method Drupal\photos\Controller\PhotosAlbumController::t() in Drupal\photos\Controller\PhotosAlbumController->albumView() (line 131 of modules\photos\src\Controller\PhotosAlbumController.php).
marianahy’s picture

marianahy commented
Assigned: Unassigned » marianahy
Issue tags: +#ciandt-contrib
marianahy’s picture

marianahy commented
Assigned: marianahy » Unassigned

Hello @nehakhadke and @nathaniel,

I couldn't apply patch, but if you can @nathaniel, just add the trait StringTranslationTrait

Regards

nathaniel’s picture

nathaniel commented
Status: Needs work » Postponed
Issue tags: -#ciandt-contrib

Thanks for the tip.

  • Nathaniel committed d109c10 on 8.x-5.x 
    Issue #2845822 by nehakhadke: $this->t() should be used instead of t().
nathaniel’s picture

nathaniel commented
Version: 8.x-4.x-dev » 8.x-5.x-dev
Status: Postponed » Fixed

Marking as fixed for now, thanks for your efforts!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.