Closed (fixed)
Project:
Delete all
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Critical
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2017 at 01:27 UTC
Updated:
1 Sep 2020 at 07:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
dipakmdhrm commentedBumping this up to Major as this really is a major feature missing from the module.
Comment #3
dipakmdhrm commentedThis is actually critical as this is blocking the stable release.
Comment #4
abhisekmazumdarComment #5
abhisekmazumdarThis patch will add the following changes:
What's Not working yet:
Note: Apply the patch on the simplytest sandbox environment gives an error.
Comment #6
abhisekmazumdarThings changed in this patch:
Comment #7
sumitmadan commentedUse $form_state to fetch the selected values.
"dsm" depends on devel module.
Use "_" hyphen instead of "-" underscore for name of form elements. Drupal will convert the hyphen to underscore while generating html.
Instead of setting and unsetting, use a condition inside foreach.
Comment #8
abhisekmazumdarThanks, @sumitmadan.
The suggested changes are done in this new patch.
Comment #9
dipakmdhrm commentedThanks for working on this @abhisekmazumdar.
This was long overdue and much needed patch. Really appreciate your work on this and this would really help us to finally make a stable release for this module.
Also, really good work on patch:
Nice catch!
Thanks for this.
Suggestions for few changes:
I think this was added by mistake.
.DS_Store is MacOS-specific folder-settings file and is not needed here.
Let's make this 'administer content'
And this as 'administer users'
Typo: selete_node_type.
We can simply call it node_type
Typo here as well
Comment #10
abhisekmazumdarThank You @dipakmdhrm for your suggestion and appreciation.
Comment #11
dipakmdhrm commentedYikes!!!!
Just realizing that 'administer content' is actually not a valid permission. It's 'administer nodes'.
Totally my fault. Apologies for misleading you in my last comment.
Can you please fix the patch?
Apologies again.
Comment #12
abhisekmazumdarI too missed crossing check it. It's my fault too. I have updated the new patch with the required changes.
Thank You.
Comment #13
dipakmdhrm commentedComment #15
dipakmdhrm commentedThank you @abhisekmazumdar for your work on this.
Really good job and this would help us to finally make a stable release for this module.
Comment #17
abhisekmazumdar