Search form needlessly extends EntityForm

The patch looks good but what if a custom/contrib module class extends methods from SearchPageForm that are part of EntityForm, like ::form(), ::actions()?

@tim.plunkett, thank you for clarifying this. Given that SearchPageForm is not marked as @api this is not a BC break.

However, the search_page config entity claims that this form is an entity form:

 *     "form" = {
 *       "add" = "Drupal\search\Form\SearchPageAddForm",
 *       "edit" = "Drupal\search\Form\SearchPageEditForm",
 *       "search" = "Drupal\search\Form\SearchPageForm",
 *       "delete" = "Drupal\Core\Entity\EntityDeleteForm"
 *     }

Also the docblock of \Drupal\search\Plugin\SearchInterface::searchFormAlter() makes a reference to \Drupal\search\Form\SearchPageForm::form() and that shold be adapted too.

marking as novice since it seems the remaining work consists of minor annotation and code comment fixes.

Please don't leave assigned for more than a day (or at all - sometimes better just to leave a comment if you are immediately working on it)

#5 still not addressed.

Seems to be the same patch?

@pwolanin,

so, reroll to 8.4-x-dev?

Ok, seems #10 is a re-roll for 8.4.x, but not labeled as such. Seems like tim's patch doesn't apply to 8.4.x using git apply

Here are also the fixes suggested by claudiu.cristea.

@pwolanin, Indeed, I suggested that entity "search" form is not an entity form and should be removed from annotation. This is correct, hope no custom or contrib code has referred the form by using the "search" key.

Looks good.

This is correct, hope no custom or contrib code has referred the form by using the "search" key.

I've checked search_api - shouldn't be impacted. Tests pass too.

Committed/pushed to 8.4.x, thanks!