Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add API documentation to the UrlEncode process plugin.
Comment | File | Size | Author |
---|---|---|---|
#11 | 2845491-11.patch | 967 bytes | jofitz |
#11 | interdiff-9-11.txt | 1.77 KB | jofitz |
#9 | 2845491-9.patch | 1.92 KB | jofitz |
#9 | interdiff-2-9.txt | 749 bytes | jofitz |
#2 | 2845491-1.patch | 1.72 KB | quietone |
Comments
Comment #2
quietone CreditAttribution: quietone as a volunteer commentedComment #4
quietone CreditAttribution: quietone as a volunteer commentedThe failure doesn't seem related, so retesting.
Comment #5
quietone CreditAttribution: quietone as a volunteer commentedPassed, so time to NR.
Comment #6
phenaproximaSelf-assigning for review.
Comment #8
ultimikeIf the source URL is "http://example.com/this is a url with spaces.html", this process plugin will return "http://example.com/this%20is%20a%20url%20with%20spaces.html"
Comment #9
jofitz CreditAttribution: jofitz at ComputerMinds commentedAdd more explanation to the example, as suggested by @ultimike.
Comment #10
phenaproxima'urlencoding' is not a word. Also, kinda passive-voice. Maybe we could rephrase this as "URL-encodes the input value"?
I think we could strike this entire sentence. It does not explain anything about the plugin itself, just about how it interacts with a migration...under certain circumstances.
s/url/URL.
This should be {@inheritdoc}.
Comment #11
jofitz CreditAttribution: jofitz at ComputerMinds commentedChanges in response to the code review by @phenaproxima in #10.
Comment #12
phenaproximaLooks good to me.
Comment #14
xjmShort and sweet. Thanks, all! Committed to 8.4.x, and backported to 8.3.x as a documentation improvement.