Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Jan 2017 at 23:54 UTC
Updated:
27 Mar 2017 at 16:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedComment #3
phenaproximaSelf-assigning for review.
Comment #5
phenaproximaThis seems incomplete :)
The first sentence needs to end with a colon, and both items in the input value need to be explained.
We need an explanation of what this example does. And maybe another example as well, if it would be helpful.
Comment #6
jofitzChanges in response to code review:
Comment #7
phenaproximaSelf-assigning for review.
Comment #8
phenaproximaThis effectively repeats the short description. We're going to need to either explain this a lot more thoroughly (i.e., by linking to the main documentation for the D8 routing system) or remove it altogether.
Can we add an example showing what will be returned if you pass an internal path like /admin/content as the source value?
Comment #9
jofitzComment #10
phenaproximaI like it.
Comment #11
alexpottCommitted and pushed 2cfd4d7 to 8.4.x and 63ab9aa to 8.3.x. Thanks!