Closed (fixed)
Project:
Drupal core
Version:
8.3.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
20 Jan 2017 at 23:53 UTC
Updated:
2 Mar 2017 at 00:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedComment #3
phenaproximaSelf-assigning for review.
Comment #5
phenaproximas/source/input. And let's say either "runs it through the transliteration service" or "transliterates it".
Not sure if the last sentence is helpful or confusing. Maybe we should axe it?
Comment #6
Winthropian commentedRefined text
Comment #7
phenaproximaI reviewed this carefully in person at Boston sprint weekend. RTBC assuming the tests pass (and why wouldn't they). Thanks, @Winthropian!
Comment #8
tstoecklerTrailing whitespace.
Leaving RTBC in the hope that that can be fixed on commit.
Comment #9
xjmStraightforward code documentation improvements can always go into any patch release, alpha, beta, or RC, so please always file them against the production branch (currently 8.3.x). Thanks!
Comment #10
xjmThis patch has some trailing whitespace that needs to be cleaned up.
Comment #11
xjmOr what @tstoeckler said, yes. Sorry, missed the comment. In general, committers editing things on commit is undesirable, and in the case of this patch, which is not urgent, the patch author can learn from it for future patches also. :)
Comment #12
MaskyS commentedRemoved whitespaces.
Comment #13
MaskyS commentedRemoved whitespaces.
Comment #14
phenaproximaNothing objectionable here. Thanks!
Comment #15
xjmHm, I thought I posted this feedback already but apparently I did not! Can we put single quotes around the example values? I got confused by it the first time I read it. Thanks!
Comment #16
jofitzAdded single quotes as requested by @xjm.
Comment #17
phenaproximaLooks made right. Thanks, @Jo Fitzgerald.
Comment #19
xjmThanks all! Committed to 8.4.x and cherry-picked to 8.3.x.