When this was a sandbox, the files and namespaces were named adobeanalytics. When the project was created from the sandbox it was given the name adobe_analytics. The project name and namespace is now out of sync. These should be the same. I have looked and there doesn't seem to be a way to update the project name. So the only option is to rename the files and the namespaces to adobe_analytics.

CommentFileSizeAuthor
#5 2844242-rename-files-5.patch39.74 KBkmoll
#2 2844242-rename-files-2.patch23.89 KBkmoll
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kmoll created an issue. See original summary.

kmoll’s picture

kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commented
FileSize
2844242-rename-files-2.patch23.89 KB

I have updated the filenames and namespaces.

kmoll’s picture

kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commented
Status: Active » Needs review
jribeiro’s picture

jribeiro CreditAttribution: jribeiro at CI&T for Pfizer, Inc. commented
Status: Needs review » Needs work

@Kevin,

The file AdobeanalyticsAdminSettings.php must be renamed to AdobeAnalyticsAdminSettings.php otherwise an exception will be triggered:

InvalidArgumentException: Class "\Drupal\adobe_analytics\Form\AdobeAnalyticsAdminSettings" does not exist. in Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition() (line 24 of /home/jribeiro/Projects/drupal8-sandbox1/core/lib/Drupal/Core/DependencyInjection/ClassResolver.php).

kmoll’s picture

kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
2844242-rename-files-5.patch39.74 KB

I have updated the patch to include the renaming of that file.

jribeiro’s picture

jribeiro CreditAttribution: jribeiro at CI&T for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Now it is working :)

+1 RTBC

  • kmoll committed d9d6fb5 on 8.x-1.x 
    Issue #2844242 by kmoll, jribeiro: Rename Files

  • kmoll committed a25f98b on 8.x-1.x 
    Issue #2844242 by kmoll, jribeiro: Rename Files - deleted old file
kmoll’s picture

kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commented
Status: Reviewed & tested by the community » Needs review

Thanks @jribeiro. Committed.

kmoll’s picture

kmoll CreditAttribution: kmoll at Appnovation for Pfizer, Inc. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.